Re: [Xen-devel] [PATCH v5 7/9] tools: arm: prepare guest FDT building for multiple RAM banks

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 22/05/14 10:46, Ian Campbell wrote:
> -    assert(rambank_size[0] != 0);
> +    assert(dom->rambank_size[0] != 0);
>       assert(ramsize == 0); /* Too much RAM is rejected above */
>
>       dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) * p2m_size);
> @@ -354,11 +353,10 @@ int arch_setup_meminit(struct xc_dom_image *dom)
>           dom->p2m_host[pfn] = INVALID_MFN;
>
>       /* setup initial p2m and allocate guest memory */
> -    for ( i = 0; rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
> -    {
> +    for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ ) {
We are in libxc, so the previous coding style was valid, i.e:
for ( ... )
{
}

Other than this minor change:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel