Re: [Xen-devel] [PATCH v4 4/5] arch/x86: Replace plain strings with constants

[Matt Fleming <matt@xxxxxxxxxxxxxxxxx>]

On Fri, 16 May, at 10:41:43PM, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
>  arch/x86/kernel/setup.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index f41f648..7a67f5d 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -924,11 +924,11 @@ void __init setup_arch(char **cmdline_p)
>  #endif
>  #ifdef CONFIG_EFI
>       if (!strncmp((char *)&boot_params.efi_info.efi_loader_signature,
> -                  "EL32", 4)) {
> +                             EFI32_LOADER_SIGNATURE, 4)) {
>               set_bit(EFI_BOOT, &efi.flags);
>               set_bit(EFI_DIRECT, &efi.flags);
>       } else if (!strncmp((char *)&boot_params.efi_info.efi_loader_signature,
> -                  "EL64", 4)) {
> +                             EFI64_LOADER_SIGNATURE, 4)) {
>               set_bit(EFI_BOOT, &efi.flags);
>               set_bit(EFI_DIRECT, &efi.flags);
>               set_bit(EFI_64BIT, &efi.flags);

Conceptually this change is a nice cleanup, but you've also changed the
indentation. Please don't do that, stick with the existing format.

-- 
Matt Fleming, Intel Open Source Technology Center

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel