[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 02/14] libxenstore.so: add support for systemd

On Wed, May 21, 2014 at 03:56:54PM +0100, Ian Campbell wrote:
> On Wed, 2014-05-21 at 15:35 +0100, Ian Campbell wrote:
> > > +
> > > +/*
> > > + * We list stdin, stdout and stderr simply for documentation purposes
> > > + * and to help our array size fit the number of expected sockets we
> > > + * as sd_listen_fds() will return 5 for example if you set the socket
> > > + * service with 2 sockets.
> > 
> > Please can we get rid of this list (which is bad enough in itself but
> > the three spurious entries are ludicrous) and just
> > etc and use those for lookups, as I described in
> > <1399971222.11314.27.camel@xxxxxxxxxxxxxxxxxxxxxx>?
> Also I thought that we decided that the mapping from the indexes here to
> the functionality need to be documented as well, I'm not seeing that, at
> least not based on a skim of the other subject lines in this series.

I didn't like the #define approach so wanted to pitch it again under
new usage, I'll be sure to add something once a final approach is

Please note that another reason for tucking things away under a list
and library was to *eventually* remove the different definitions of
these socket's paths. That code is already split up but can be brought
together under libxenstore and for the systemd case the list can be
used to to do an O(1) lookup of the socket path in the list. If we
use just #defines we would just be adding more #defines for other
things other than the file descriptor for systemd, we'd have it also
for mode, and paths. The list therefore seemed more attractive.

Let me know.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.