[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] libxl: Reset toolstack_save file position in libxl

Andrew Cooper writes ("Re: [PATCH v2] libxl: Reset toolstack_save file position 
in libxl"):
> On 19/05/2014 19:36, Jason Andryuk wrote:
> > toolstack_save data is written to a temporary file in libxl and read
> > back in libxl-save-helper.  The file position must be reset prior to
> > reading the file, which is done in libxl-save-helper with lseek.
> >
> > lseek is unsupported for pipes and sockets, so a wrapper passing such an
> > fd to libxl-save-helper fails the lseek.  Moving the lseek to libxl
> > avoids the error, allowing the save to continue.
> >
> > Signed-off-by: Jason Andryuk <andryuk@xxxxxxxx>
> > Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Ian: As noted previously, this should be a backport candidate.

We normally do backports only for bugs (and not even all bugs).  I'm
afraid that I don't see how the current arrangements are a bug.

See my other mail.  Perhaps the answer to that will explain to me how
the current are a bug, rather than simply less convenient and flexible
than they could be.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.