[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 02/19] VPMU: Mark context LOADED before registers are loaded

On 05/19/2014 10:18 AM, Jan Beulich wrote:
On 13.05.14 at 17:53, <boris.ostrovsky@xxxxxxxxxx> wrote:
Because a PMU interrupt may be generated as soon as PMU registers are loaded
more precisely, as soon as HW PMU is "armed") we don't want to delay marking
context as LOADED until after registers are loaded. Otherwise during
handling VPMU_CONTEXT_LOADED may not be set and this could be confusing.

(Technically, only SVM needs this change right now since VMX will "arm" PMU
during VMRUN when global control register is loaded from VMCS. However, both
AMD and Intel code will require this patch when we introduce PV VPMU).

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Reviewed-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
Tested-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
With patch 1 needing further work, but this patch (for example) being
ready to go in, could you please indicate up to which point the series,
leaving out patch 1, could be applied if no other comments arise?

My thinking was that once there is feeling that Xen component is starting to get closer to acceptable shape I would post Linux kernel part and have at least one (preferably a couple) round of comments to avoid making changes to hypervisor once code is there. Or at least minimize the amount of these changes.

And I in fact was planning to do it this week.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.