[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH RFC 2/9] x86/traps: Make panic and reboot paths safe during early boot

>>> On 15.05.14 at 17:46, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/05/14 13:12, Jan Beulich wrote:
>>> On 15/05/14 11:19, Jan Beulich wrote:
>>>> Hmm, tying SMP boot and IRQ enabling together seems a little
>>>> problematic, even if on x86 the former happens soon after the latter
>>>> right now. Perhaps these ought to be distinct states?
>>> Which states would you suggest then?
>> Perhaps "IRQs enabled" and "SMP boot"?
> I donât see how these would help in this case.

I didn't say it would make a difference here, all I said was that it's
not very consistent.

> For both machine_{halt,reboot}(), the local_irq_enable() is purely to
> prevent tripping the assertion in
> on_selected_cpus()/smp_call_function(), which is an smp thing rather
> than an irq thing.
> I think SYS_STATE_smp_boot is sufficient here. Perhaps I could reword
> the commit message to put less emphasis on "enabling irqs" and more on
> the smp side?

That might help.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.