Re: [Xen-devel] [PATCH v6 3/4] xen: iommu: Define PAGE_{SHIFT, SIZE, ALIGN, MASK)_64K

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.05.14 at 14:56, <julien.grall@xxxxxxxxxx> wrote:
> Also add IOMMU_PAGE_* helper macros to help creating PAGE_* defines.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

with a small nit:

>  #define PAGE_SHIFT_4K       (12)
> -#define PAGE_SIZE_4K        (1UL << PAGE_SHIFT_4K)
> -#define PAGE_MASK_4K        (((u64)-1) << PAGE_SHIFT_4K)
> -#define PAGE_ALIGN_4K(addr) (((addr) + PAGE_SIZE_4K - 1) & PAGE_MASK_4K)
> +#define PAGE_SIZE_4K        IOMMU_PAGE_SIZE(4K)
> +#define PAGE_MASK_4K        IOMMU_PAGE_MASK(4K)
> +#define PAGE_ALIGN_4K(addr) IOMMU_PAGE_ALIGN(4K, (addr))

Pointless parentheses around addr.

> +#define PAGE_SHIFT_64K          (16)
> +#define PAGE_SIZE_64K           IOMMU_PAGE_SIZE(64K)
> +#define PAGE_MASK_64K           IOMMU_PAGE_MASK(64K)
> +#define PAGE_ALIGN_64K(addr)    IOMMU_PAGE_ALIGN(64K, (addr))

Same here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel