[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART

At 14:50 +0100 on 12 May (1399902612), Jan Beulich wrote:
> -EAGAIN being a return value we want to return to the actual caller in
> a couple of cases makes this unsuitable for restart indication, and x86
> already developed two cases where -EAGAIN could not be returned as
> intended due to this (which is being fixed here at once).
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Definitely an improvement on what's there, so:
Reviewed-by: Tim Deegan <tim@xxxxxxx>

Some of the paths are a bit complex now, e.g. a preemption
point being reported as EINTR by __put_page_type(), translated to
ERESTART by relinquish_memory(), then to EAGAIN by domain_kill().

Are there cases where we want to return EINTR to the guest, or could
we maybe use it everywhere and drop ERESTART?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.