[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/4] x86/nmi: wait for all CPUs in check_nmi_watchdog()

>>> On 14.05.14 at 16:09, <david.vrabel@xxxxxxxxxx> wrote:
> x86/nmi: wait for all CPUs in check_nmi_watchdog()
> The counting of a CPUs NMIs in check_nmi_watchdog() is only reliable
> if all CPUs have been spinning for 5 or more ticks.  Whilst its highly
> implausible that this won't happen in practise, explicitly wait so it's
> clear that this is required.

The thing is that I actually consider the early continuation to be
desirable - there's no need for the BP to actually wait for the APs
to finish their wait loop, as long as they progressed far enough
into it. If you added a flag telling the others to bail as soon as the
master exited its waiting, that would look more acceptable to me.

Agreed we're not talking about big time differences here, but
we shouldn't be making booting slower than it needs to be. Btw.,
did you check how modern Linux deals with the same issue (last I
looked was many releases ago)?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.