Re: [Xen-devel] [PATCH v5 01/14] xen/arm: Introduce flush_tlb_domain

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/14/2014 02:28 PM, Ian Campbell wrote:
> On Tue, 2014-05-13 at 16:50 +0100, Julien Grall wrote:
>> The pattern p2m_load_VTTBR(d) -> flush_tlb -> p2m_load_VTTBR(current->domain)
>> is used in few places.
>>
>> Replace this usage by flush_tlb_domain which will take care of this pattern.
>> This will help to the lisibility of apply_p2m_changes which begin to be big.
> 
> "lisibility"? Did you mean to type "visibility"? I think the word you
> really wanted was "readability".

I meant readability. It was a quick & bad translation from French.

>> diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/asm-arm/flushtlb.h
>> index 329fbb4..5722c67 100644
>> --- a/xen/include/asm-arm/flushtlb.h
>> +++ b/xen/include/asm-arm/flushtlb.h
>> @@ -25,6 +25,9 @@ do {                                                       
>>              \
>>  /* Flush specified CPUs' TLBs */
>>  void flush_tlb_mask(const cpumask_t *mask);
>>  
>> +/* Flush CPU's TLBs for the speficied domain */
> 
> "Specified"
> 
> Other than those two nits:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks!

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel