[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v5 05/14] xen/passthrough: rework hwdom_pvh_reqs to use it also on ARM

Hardware domain on ARM will have the same requirements as hwdom PVH when iommu
is enabled. Both PVH and ARM guest has paging mode translate enabled, so Xen
can use it to know if it needs to check the requirements.

Rename the function and remove "pvh" word in the panic message.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Cc: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>

    Changes in v4:
        - Rebase on the latest staging (hwdom series was pushed)
        - Remove is_phv_domain bits ... and update the next patch
       (should be #7) to create in new function arch_iommu_check_dom0_reqs.
        - Update printed message to be more readable
    Changes in v2:
        - IOMMU can be disabled on ARM if the platform doesn't have
 xen/drivers/passthrough/iommu.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index 96a79ce..ccb354d 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -130,13 +130,17 @@ int iommu_domain_init(struct domain *d)
     return hd->platform_ops->init(d);
-static void __hwdom_init check_hwdom_pvh_reqs(struct domain *d)
+static void __hwdom_init check_hwdom_reqs(struct domain *d)
+    if ( !paging_mode_translate(d) )
+        return;
     if ( !iommu_enabled )
         panic("Presently, iommu must be enabled for pvh dom0\n");
     if ( iommu_passthrough )
-        panic("For pvh dom0, dom0-passthrough must not be enabled\n");
+        panic("Dom0 uses paging translated mode, dom0-passthrough must not be "
+              "enabled\n");
     iommu_dom0_strict = 1;
@@ -145,8 +149,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d)
     struct hvm_iommu *hd = domain_hvm_iommu(d);
-    if ( is_pvh_domain(d) )
-        check_hwdom_pvh_reqs(d);
+    check_hwdom_reqs(d);
     if ( !iommu_enabled )

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.