[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC] libxc: check return values on mmap() and madvise() on xc_alloc_hypercall_buffer()

On Mon, May 12, 2014 at 5:03 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> I hadn't noticed that there was a failure specific PERROR at the out
> label location. For this to make sense it would need to be:
>     rc = madvise(p, npages * XC_PAGE_SIZE, MADV_DONTFORK);
>     if ( rc < 0 )
>     {
>         PERROR("xc_alloc_hypercall_buffer: madvise failed");
>          goto out;
>     }
>     ....
>  out:
>     the cleanup

OK I'll move the PERROR() above, and will fold this into my series of
systemd patches as I have a second spin coming up.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.