[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] switch hypercall restart indication from -EAGAIN to -ERESTART

>>> On 12.05.14 at 16:13, <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> On Mon, 2014-05-12 at 14:50 +0100, Jan Beulich wrote:
>> -EAGAIN being a return value we want to return to the actual caller in
>> a couple of cases makes this unsuitable for restart indication, and x86
>> already developed two cases where -EAGAIN could not be returned as
>> intended due to this (which is being fixed here at once).
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx (ARM and common)
> Two comments:
> I notice some existing ERESTART's in xen/drivers/passthrough/iommu.c --
> is that a problem or do the adjustments here take that into account?

Yes, these were independent of the other call trees and hence I
already used to new error code there when adding that code.

> This struck me as odd:
>> @@ -590,6 +590,8 @@ int domain_kill(struct domain *d)
>>          rc = domain_relinquish_resources(d);
>>          if ( rc != 0 )
>>          {
>> +            if ( rc == -ERESTART )
>> +                rc = -EAGAIN;
> until I realised that you intended for ERESTART to only be used
> internally within the hypervisor and not to be exposed to the guest.
> Perhaps insert the word "internal" into the Subject?

Good idea, done.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.