Re: [Xen-devel] [PATCH v4 01/15] xenstore: add support for a retry open limit on xenstored

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-05-12 at 14:50 +0100, Ian Jackson wrote:
> Luis R. Rodriguez writes ("[PATCH v4 01/15] xenstore: add support for a retry 
> open limit on xenstored"):
> > This adds support for a customizable retry limit on trying to open
> > the xenstored unix domain socket, each retry is separated by 1 second.
> > This should allow us to simplify both our LSB init scripts. For systemd
> > we'll use socket activation.
> 
> I'm afraid I fundamentally disagree with this timeout/polling based
> approach.

It already exists, all the first two patches in this series are doing is
moving it from /etc/init.d/xencommons into the client utility.

>   Why is it necessary ?

If xenstored has failed to start for some reason then the xenstore-write
in the initscript would potentially block forever without a timeout.

As for the retry -- I suppose xenstored forks before it is really ready?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel