[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen-blkback: defer freeing blkif to avoid blocking xenwatch

On 12/05/14 11:41, Valentin Priescu wrote:
> On Mon, May 12, 2014 at 11:39 AM, David Vrabel <david.vrabel@xxxxxxxxxx> 
> wrote:
>> If xen_blkif_disconnect() returns -EBUSY, nothing will trigger the
>> reconnect.
> Yeah, I should do something like:
> err = xen_blkif_disconnect(be->blkif);
> if (err) {
>     xenbus_dev_fatal(dev, err, "disconnecting %s",
>             dev->otherend);

I think that's ok, but the error message should be "pending I/O".  You
don't need to include the name of the otherend in the error message.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.