Re: [Xen-devel] [PATCH v7 7/9] ioreq-server: add support for multiple servers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-09 at 10:50 +0100, Paul Durrant wrote:
> > One minor nit:
> > 
> > > +    if (!pagebuf.nr_ioreq_server_pages ^ !pagebuf.ioreq_server_pfn) {
> > > +        ERROR("XC_SAVE_ID_HVM_NR_IOREQ_SERVER_PAGES = %"PRIx64"
> > XC_SAVE_ID_HVM_IOREQ_SERVER_PFN = %"PRIx64,
> > > +              pagebuf.nr_ioreq_server_pages, pagebuf.ioreq_server_pfn);
> > 
> > This is a very long line, and I fear the resulting message will be a bit
> > meaningless. How about:
> >         ERROR("Inconsistent IOREQ server settings
> > (pfn=%PRIx64",nr=%"PRIx64")",
> >                pagebuf....)
> > ?
> > 
> 
> Agreed. I won't rework the series for this. I'll make a note and fix it 
> afterwards.

Fine by me, unless you are respining for some other reason of course.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel