Re: [Xen-devel] [PATCH v4 3/9] tools/libxc: Stream specification and some common code

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 07/05/14 12:57, Ian Campbell wrote:
> On Wed, 2014-04-30 at 19:36 +0100, Andrew Cooper wrote:
>> diff --git a/tools/libxc/saverestore/stream_format.h 
>> b/tools/libxc/saverestore/stream_format.h
>> new file mode 100644
>> index 0000000..efcca60
>> --- /dev/null
>> +++ b/tools/libxc/saverestore/stream_format.h
> 
> Reference to the spec (which doesn't appear to be in this series
> anywhere BTW)
> 
>> @@ -0,0 +1,158 @@
>> +#ifndef __STREAM_FORMAT__H
>> +#define __STREAM_FORMAT__H
>> +
>> +#include <inttypes.h>
>> +
>> +/* TODO - find somewhere more appropriate. rec_tsc_info needs it for 64bit 
>> */
> 
> You seem to use it on all of them though. Can we not use explicit
> padding, as you seem to do for many of the other structs?

Yes, rec_tsc_info needs a trailing uint32_t _res1 field to match the spec.

There should be no need to __packed on any of the structures.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel