Re: [Xen-devel] [PATCH V4 19/24] xl: introduce and use "xl-json" format

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 06, 2014 at 04:17:53PM +0100, Wei Liu wrote:
[...]
> > >  
> > > +static void nic_update_default(libxl_domain_config *d_config)
> > > +{
> > > +    int i;
> > > +    libxl_device_nic *nic;
> > > +
> > > +    for (i = 0; i < d_config->num_nics; i++) {
> > > +        nic = &d_config->nics[i];
> > > +
> > > +        if (default_vifscript) {
> > > +            free(nic->script);
> > > +            nic->script = strdup(default_vifscript);
> > > +        }
> > 
> > You can use the replace_string() helper for all these I think.
> > 
> > Except -- what about any explicitly configured script (ie. vif =
> > ['script=blargle']), does this not replace it with the default? Should
> > this be if !nic->script ?
> > 
> 
> Haven't thought about this. This is actually just code motion. I think
> you just discovered a bug. One more patch added to queue!
> 

Actually I was wrong, this code motion is buggy and I will fix it.
There's no bug in the original code.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel