Re: [Xen-devel] [PATCH V4 14/24] libxl: introduce libxl_key_value_list_length

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-01 at 13:58 +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/libxl/libxl.c |   12 ++++++++++++
>  tools/libxl/libxl.h |    1 +
>  2 files changed, 13 insertions(+)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index dbba7ca..08c4f54 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -216,6 +216,18 @@ int libxl_string_list_length(const libxl_string_list 
> *psl)
>      return i;
>  }
>  
> +int libxl_key_value_list_length(libxl_key_value_list *pkvl)
> +{
> +    int i = 0;
> +    libxl_key_value_list kvl = *pkvl;
> +
> +    if (kvl)
> +        while (kvl[i])
> +            i += 2;
> +
> +    return i / 2;

"+= 2" *and* "/ 2"?

Oh I see, values can be NULL.

It might sound stupid but:
        while(kvl[i]) {
                i++; /* Key */
                i++; /* Values, could be NULL */
might be clearer?

Or:
        while (kvl[2*i]) /* Only check keys */
                i++
        return i;

The key think about both proposals is the presence of a comment ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel