Re: [Xen-devel] [PATCH OSSTEST v2 11/15] distros: attempt pvgrub support for PV Wheezy too.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST v2 11/15] distros: attempt pvgrub 
support for PV Wheezy too."):
> On Fri, 2014-05-02 at 14:11 +0100, Ian Jackson wrote:
> >   (As were the "" before.  Not sure why they were there.)
> 
> Does the quoting of the termination marker have an impact on the way
> things within the heredoc are interpreted?

Yes, but "" is the same as no quoting.  Saying <<'EOF' prevents
variable interpolation.

> > > -    my $extra_packages = "pv-grub-menu" if $xopts{PvMenuLst};
> > > +    $xopts{EnableBackports} = 1
> > > + if $xopts{PvMenuLst} and $suite eq "wheezy";
> > 
> > I normally write this as   $suite =~ m/wheezy/
> 
> OK. (But OOI why?)

It makes it easier to add |jessie when the problem remains unfixed.
(Also if someone has some kind of derivative called "wheezy-blarf", it
is more likely to be right than the exact match.)

> > > +    my $extra_packages = "pv-grub-menu".
> > > + ($xopts{EnableBackports} ? "/$suite-backports" : "")
> > > +     if $xopts{PvMenuLst};
> > 
> > I think this is a rather strange way of doing things.  It's
> > backwards.  What you mean is probably something like this:
> > 
> >   +    my $extra_packages = "pv-grub-menu".
> >   + ($suite =~ m/wheezy/ ? "/$suite-backports" : "")
> >   +     if $xopts{PvMenuLst};
> > 
> >   +    $xopts{EnableBackports} ||= $extra_packages =~ m#/\S+-backports\b#;
> > 
> > or even better, do away with the EnableBackports xopt altogether and
> > have preseed_base do it itself automatically.
> 
> OK.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel