Re: [Xen-devel] [PATCH OSSTEST v2 14/15] distros: add branch infrastructure

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 15:04 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 14/15] distros: add branch 
> infrastructure"):
> > Since the distro nightlies are not version controlled we cannot use the 
> > usual
> > mechanisms for detecting regressions. Instead compare each run against its
> > predecessor, determined using sg-check-tested.
> > 
> > XXX needs testing in production environment.
> ...
> > --- a/ap-fetch-version
> > +++ b/ap-fetch-version
> > @@ -77,6 +77,10 @@ gnulib-libvirt)
> ...   ;;
> > +distros)
> > +   # None, this is just a regular test.
> > +   echo latest
> > +   ;;
> 
> Is doing this really easier than doing it in cr-daily-branch ?

You mean avoiding calling ap-fetch-version for this branch? I didn't
try, I'd have thought it would involve a handful of special cases.
Although if you mean to handle none here (cf your second comment) then
that might work nicely.

> And I think perhaps ...
> 
> > diff --git a/cri-common b/cri-common
> > index f472927..c02ad06 100644
> > --- a/cri-common
> > +++ b/cri-common
> > @@ -43,6 +43,7 @@ select_xenbranch () {
> >     linux-*)                tree=linux;     xenbranch=xen-unstable ;;
> >     linuxfirmware)      tree=linuxfirmware; xenbranch=xen-unstable ;;
> >     libvirt)                tree=libvirt;   xenbranch=xen-unstable ;;
> > +   distros)                tree=distros;   xenbranch=xen-unstable ;;
> 
> ... this should be "tree=none".  What do you think ?

I've no idea... The logic is that there is no pushed thing there is no
tree?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel