[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: traps: Add missing 0x in bad_trap

On 05/02/2014 02:21 PM, Ian Campbell wrote:
> On Fri, 2014-05-02 at 14:19 +0100, Julien Grall wrote:
>> On 05/02/2014 01:56 PM, Ian Campbell wrote:
>>> On Thu, 2014-04-10 at 12:44 +0100, Julien Grall wrote:
>>>> The syndrome value is printed in hexadecimal. Prefix it by 0x for less
>>>> confusion.
>>>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>>> I've acked + applied this. Irrespective of any apparent move to prefer %
>>> #x this is an improvement.
>> Thanks. So what was the conclusion about % vs #x. Which one shall we use?
> I'm perfectly fine with 0x%x for ARM code. I think Andy's comment about
> "Xen moving towards" was overstating things somewhat.

Ok. FIY, Jan Beulich asked me to change some 0x%x into #x in common code
when I sent patch a couple of month ago.

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.