[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5] Autoconf: add options to enable spice and usbredir in qemu upstream

Il 02/05/2014 12:37, Ian Campbell ha scritto:
On Wed, 2014-04-23 at 17:23 +0200, Fabio Fantoni wrote:
Added configure options to enable spice and usbredir to upstream
qemu build done with xen.
CCing qemuu maintainers for their feedback on the suitability of doing

@@ -1423,6 +1426,8 @@ Optional Features:
    --disable-seabios       Disable SeaBIOS (default is ENABLED)
    --disable-debug         Disable debug build of tools (default is ENABLED)
    --enable-blktap1        Enable blktap1 tools (default is DISABLED)
+ --enable-qemuu-spice    Enable Spice build on qemu upstream
+ --enable-qemuu-usbredir Enable usb redirection build on qemu upstream
This indicates that your AC_ARG_ENABLE invocations are missing a leading
space. (it'd be nice if this didn't have to happen manually...)

diff --git a/config/Tools.mk.in b/config/Tools.mk.in
index 0bdf37a..efe5bc6 100644
--- a/config/Tools.mk.in
+++ b/config/Tools.mk.in
@@ -54,6 +54,7 @@ CONFIG_SEABIOS      := @seabios@
  CONFIG_QEMU_TRAD    := @qemu_traditional@
  CONFIG_QEMU_XEN     := @qemu_xen@
  CONFIG_BLKTAP1      := @blktap1@
+CONFIG_QEMUU_EXTRA_ARGS:= @qemuu_extra_args@

I don't particularly mind this but the normal way of doing this appears
to be to set something like CONFIG_QEMUU_<FEATURE> to y or n and then
handle it in tools/Makefile, see e.g. the use of QEMU_XEN_ENABLE_DEBUG.


Ian Jackson told me to do only one that contain all extra qemu options:

Thanks for any reply.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.