Re: [Xen-devel] [PATCH OSSTEST RFC] Add a flight to test seabios.org's master branch

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 12:06 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST RFC] Add a flight to test seabios.org's 
> master branch"):
> > Most of this is the usual stuff for adding a new branch.
> > 
> > cr-daily-branch needed to set REVISION_SEABIOS for the seabios
> > branch and leave it blank for others (so that Config.mk's version
> > will be used). ts-xen-build already consumes the resulting version
> > runvar but needed to be taught about the tree URL runvar.
> 
> You're introducing a push gate here.  Why not use the post-push-gate
> version for other tests ?

For now I'd like to continue to manually track actual SeaBIOS releases
rather than pull in the current master (especially for releases).

The intention of this flight is just to monitor the health of upstream
master.

> 
> > make-flight and mfi-common are updated to only build+test seabios on x86.
> > job_create_test_filter_callback is refactored a bit since the check for only
> > running qemuu tests with the xl toolstack should be common to all branches.
> > Only test jobs named *-qemuu-* are run since seabios is only used with qemuu
> > (XXX do all suitable jobs have qemuu in the name?)
> 
> I'm not sure they do.  Perhaps you should filter by the runvars
> instead.  (NB that since qemuu is the default now in xl, hvm tests not
> specifying trad are probably the ones you want.)

Will check this out again.

> > As with the qemu-mainline addition (see patch "Add a flight to test 
> > qemu.org's
> > ("mainline") master branch.") I'm not sure what to call the output branch.
> 
> tested/<something> a la /home/xen/git/linux-pvops.git I would guess.

Sorry, by branch I meant "repo", .i.e. the /home/xen/git/foo.git bit.  I
wasn't sure about using /home/xen/git/seabios.git -- I'm wary of
publishing the output of a push gate which is just for "health
monitoring" to somewhere that it might be mistaken for a Supported
thing. I was thinking of
perhaps /home/xen/git/osstest-gated/seabios.git.

> > diff --git a/ap-common b/ap-common
> > index f48d08a..468f5f9 100644
> ...
> > +: ${TREE_SEABIOS:=git://git.seabios.org/seabios.git}
> > +: ${PUSH_TREE_SEABIOS:=$XENBITS:/home/xen/git/osstest/seabios.git} # XXX 
> > ???
> > +: ${BASE_TREE_SEABIOS:=git://xenbits.xen.org/osstest/seabios.git} # XXX ???
> 
> Surely this should be a head in /home/xen/git/seabios.git ?

See above.

> > -: ${BRANCHES:=osstest xen-4.0-testing xen-4.1-testing xen-4.2-testing 
> > xen-4.3-testing xen-4.4-testing xen-unstable qemu-mainline 
> > qemu-upstream-unstable qemu-upstream-4.2-testing qemu-upstream-4.3-testing 
> > qemu-upstream-4.4-testing linux-3.10 linux-3.4 linux-arm-xen 
> > ${EXTRA_BRANCHES}}
> > +: ${BRANCHES:=osstest xen-4.0-testing xen-4.1-testing xen-4.2-testing 
> > xen-4.3-testing xen-4.4-testing xen-unstable qemu-mainline 
> > qemu-upstream-unstable qemu-upstream-4.2-testing qemu-upstream-4.3-testing 
> > qemu-upstream-4.4-testing linux-3.10 linux-3.4 linux-arm-xen seabios 
> > ${EXTRA_BRANCHES}}
> 
> Do we want this to run whenever upstream is updated then ?

I've never been quite sure about these things being here vs. daily
cronjob. SeaBIOS doesn't see a huge amount of churn compared with some
trees. Mostly I just tossed a mental coin though.

Cheers,
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel