[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 04/12] tools/libxl: use buildmakevars2header to create _paths.h

On Thu, 2014-04-24 at 10:36 +0200, Olaf Hering wrote:
> Replace usage of buildmakevars2file with buildmakevars2header. The macro
> generates a C header file, so remove code which converts shell variables
> into C defines. Also update the dependency, the macro itself creates a
> dependency to genpath for _paths.h. A temporary file is not needed
> anymore.

The penultimate sentence mentions genpath which per my comments on #2 I
think should go away. But other than that the patch is OK

> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

When you've made the genpath change in the previous patches and updated
this commit message to reflect that:
        Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> 


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.