Re: [Xen-devel] [V10 PATCH 3/4] pvh dom0: Add and remove foreign pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.05.14 at 03:45, <mukesh.rathor@xxxxxxxxxx> wrote:
> On Thu, 1 May 2014 18:19:08 +0200 Tim Deegan <tim@xxxxxxx> wrote:
>> > @@ -46,6 +44,46 @@ static inline bool_t is_epte_valid(ept_entry_t
>> > *e) return (e->epte != 0 && e->sa_p2mt != p2m_invalid);
>> >  }
>> >  
>> > +/* returns : 0 for success, -errno otherwise */
>> > +static int atomic_write_ept_entry(ept_entry_t *entryptr,
>> > ept_entry_t new,
>> > +                                  int level)
>> > +{
>> > +    bool_t same_mfn = (new.mfn == entryptr->mfn);
>> > +    unsigned long oldmfn = INVALID_MFN;
>> > +
>> > +    if ( level )
>> > +    {
>> 
>> ASSERT(!(new.sp && p2m_is_foreign(new.sa_p2mt))) here?
> 
> Yeah, I debated adding p2m_is_foreign ASSERT, but didn't because iirc 
> Jan had said he wanted to use up the non-leaf bits for something else 
> in future.  I suppose I can add it, it would be  easy
> to find it anyways....  BTW, there is no path allowing 
> superpage for foreign at present.

But .sp set implies it being a leaf entry.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel