[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [3.15-rc3] Bisected: xen-netback mangles packets between two guests on a bridge since merge of "TX grant mapping with SKBTX_DEV_ZEROCOPY instead of copy" series.

On 30/04/14 11:45, Sander Eikelenboom wrote:
     Another point would be: what *correctness* testing is actually done on the 
xen-net* patches ?
I can speak only about my patches: I have manually tested them for the usecases where they likely to make a difference, plus they went through Xenserver's full test suite several times.
     As i suspect this is again about fragmented packets .. that doesn't seem 
to be included in any test case while it actually seems to be a case which is 
hard to get right...
Beware, there are frags and frag_list which are two entirely different things with confusing names. In netback case, frags are used to pass through large packets for a long time. frag_list is used only since my grant mapping patches, to handle older guests (see comment in include/xen/interface/io/netif.h for XEN_NETIF_NR_SLOTS_MIN)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.