Re: [Xen-devel] [PATCH V9 04/12] remus: introduce a function to check whether network buffering is enabled

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Shriram Rajagopalan writes ("Re: [PATCH V9 04/12] remus: introduce a function 
to check whether network buffering is enabled"):
> On Wed, Apr 23, 2014 at 10:50 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> wrote:
> 
>     Yang Hongyang writes ("[PATCH V9 04/12] remus: introduce a function to
>     check whether network buffering is enabled"):
>     > libxl__netbuffer_enabled() returns 1 when network buffering is compiled,
>     > or returns 0 when network buffering is not compiled.
>     >
>     > If network buffering is not compiled, and the user wants to use it,
>     report
>     > a error and exit.
>     ...
>     > +ifeq ($(CONFIG_REMUS_NETBUF),y)
>     > +LIBXL_OBJS-y += libxl_netbuffer.o
>     > +else
>     > +LIBXL_OBJS-y += libxl_nonetbuffer.o
>     > +endif
> 
>     Thanks.  But I think this needs to be set somewhere ?
...
> Its already done at the autoconf level.

In another patch ?  I think this is another example of a case where
the series needs restructuring.  Semantically related pieces should be
together so that reviewing an individual patch makes sense.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel