[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Hidden symbol when debugging hypervisor


  • To: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Wed, 30 Apr 2014 11:39:31 +0200
  • Delivery-date: Wed, 30 Apr 2014 09:39:42 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Message-ID:Date:From:Organization:User-Agent: MIME-Version:To:Subject:References:In-Reply-To: Content-Type:Content-Transfer-Encoding; b=Zv34FgwqQzM/pB4D21znQ7+BjcLJQ3gAIssCyqBXRyqy333VL49E8rr5 +icqvzBXnLBV24mnko8HV6izPNxhtUk0fg6rMtB22SAVpW4TQqdVloDKB n7gL6tTY/D5V39qox2K3oDqhBvm4zUEzdmOxkI+2Tzxgbg92uH5r1bFvj 9sVpgUjZQnQGT48MnuWBdBFP4/acL7yewoqMBF95S/IGVvFW2LDiQTRxR htbJABjuq8Q4qIEpv1gg7UHeYilZZ;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 30.04.2014 11:26, George Dunlap wrote:
On 04/30/2014 10:02 AM, Dietmar Hahn wrote:
Hi,

while debugging a vmcore with the crash tool I stumpled over a little problem.
I wanted to look at the "struct csched_private" of credit scheduler and got
the contents of the "struct csched_private" of credit2.
The debug informations of the hypervisor contain 2 entries
  <1><b185e>: Abbrev Number: 8 (DW_TAG_structure_type)
     <b185f>   DW_AT_name        : (indirect string, offset: 0x9d8d):
csched_private
and
  <1><c0677>: Abbrev Number: 25 (DW_TAG_structure_type)
     <c0678>   DW_AT_name        : (indirect string, offset: 0x9d8d):
csched_private

The first is credit and the second credit2. It seems in the crash command the
second entry wins :-(.

Maybe crash has the possibility somewhere to get access to the second structure
(I couldn't find it) but for simplicity it would be better to have different
names
I think.
Are there any reasons not to rename
struct csched_private -> struct c2sched_private
or whatever?

No reasons at all -- the naming is an artifact of development.  Feel free to
send a patch renaming it.

I tried it once: 
http://lists.xen.org/archives/html/xen-devel/2013-02/msg02255.html

Jan didn't like it.


Jürgen

--
Juergen Gross                 Principal Developer Operating Systems
PSO PM&D ES&S SWE OS6                  Telephone: +49 (0) 89 62060 2932
Fujitsu                                   e-mail: juergen.gross@xxxxxxxxxxxxxx
Mies-van-der-Rohe-Str. 8                Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.