Re: [Xen-devel] [PATCH RFC 1/4] x86/mm: Shadow and p2m changes for PV mem_access

[Tamas Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

+ Â Â/* For PV domains we only support rw, rx, rx2rw, rwx access permissions */

There is a bit of discrepancy between the comment and the code here. Also, could you briefly explain why only these permissions are supported?

Â

+ Â Âif ( unlikely(p2ma != p2m_access_r &&
+ Â Â Â Â Â Â Â Â Âp2ma != p2m_access_rw &&
+ Â Â Â Â Â Â Â Â Âp2ma != p2m_access_rx &&
+ Â Â Â Â Â Â Â Â Âp2ma != p2m_access_rwx &&
+ Â Â Â Â Â Â Â Â Âp2ma != p2m_access_rx2rw) )
+ Â Â Â Âreturn -EINVAL;

Â

+ Â Â/* For PV domains we only support r, rw, rx, rwx access permissions */

Code/comment discrepancy again.

Â

+ Â Âif ( p2m->default_access != p2m_access_r &&
+ Â Â Â Â p2m->default_access != p2m_access_rw &&
+ Â Â Â Â p2m->default_access != p2m_access_rx &&
+ Â Â Â Â p2m->default_access != p2m_access_rwx &&
+ Â Â Â Â p2m->default_access != p2m_access_rx2rw )
+ Â Â Â Âreturn -EINVAL;
+

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel