[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4] hypercall/mem: Introduce XENMEM_machphys_compat_mfn_list
On 29/04/14 10:59, Jan Beulich wrote: >>>> On 29.04.14 at 11:46, <andrew.cooper3@xxxxxxxxxx> wrote: >> Changes in v4: >> * Use same visibility as XENMEM_machphys_mfn_list. Leave note about next >> subop. > I'm fine with this now with one possible minor correction (could be done > while committing, so no need to resubmit just because of this): > >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -187,6 +187,16 @@ typedef struct xen_machphys_mfn_list >> xen_machphys_mfn_list_t; >> DEFINE_XEN_GUEST_HANDLE(xen_machphys_mfn_list_t); >> >> /* >> + * For a compat toolstack domain, this is identical to >> + * XENMEM_machphys_mfn_list. >> + * >> + * For a non compat toolstack domain, this functions similarly to >> + * XENMEM_machphys_mfn_list, but returns the mfns making up the >> compatibility >> + * m2p table. >> + */ >> +#define XENMEM_machphys_compat_mfn_list 25 > I think it is now at least misleading to say "toolstack domain" in the > comment above - in both cases I'd prefer this to just say "caller". > > Jan > Ok - I am happy with that. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |