[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 4/9] Clear AC bit in RFLAGS to protect Xen itself by SMAP



>>> On 29.04.14 at 11:27, <feng.wu@xxxxxxxxx> wrote:
> May I move the definition of SAVE_ALL (or more related code, such as, 
> SAVE_VOLATILE, etc.) from " xen/include/asm-x86/x86_64/asm_defns.h " to " 
> xen/include/asm-x86/asm_defns.h ", since I got an build error after adding a 
> parameter to marco SAVE_ALL like this, which makes me think it should be 
> defined after ASM_CLAC?

No problem (and in fact I wouldn't mind you merging all of
x86_64/asm_defns.h into the other file - that due at some point
anyway), but I'm afraid we'd want this to be yet another separate
prerequisite patch - not sure if you're up to that, or if you wouldn't
find it simpler to keep SAVE_ALL being a C macro then.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.