Re: [Xen-devel] [PATCH RFC 05/23] libxc: remove usage of "daylight" variable

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-16 at 16:13 +0200, Roger Pau Monne wrote:
> FreeBSD doesn't implement the XSI extension that mandates the presence
> of the daylight variable as described in:
> 
> http://pubs.opengroup.org/onlinepubs/009696799/functions/tzset.html

Wow, what an interesting thing to expose.


> So avoid using it for portability reasons. Use tm_isdst instead to
> decide if daylight savings time conversions should be used or not.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxc/xtl_logger_stdio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/libxc/xtl_logger_stdio.c b/tools/libxc/xtl_logger_stdio.c
> index 47ee257..d8646e0 100644
> --- a/tools/libxc/xtl_logger_stdio.c
> +++ b/tools/libxc/xtl_logger_stdio.c
> @@ -64,7 +64,7 @@ static void stdiostream_vmessage(xentoollog_logger 
> *logger_in,
>          fprintf(lg->f, "%04d-%02d-%02d %02d:%02d:%02d %s ",
>                  lt->tm_year+1900, lt->tm_mon+1, lt->tm_mday,
>                  lt->tm_hour, lt->tm_min, lt->tm_sec,
> -                tzname[daylight ? !!lt->tm_isdst : 0]);
> +                tzname[!!lt->tm_isdst]);
>      }
>      if (lg->flags & XTL_STDIOSTREAM_SHOW_PID)
>          fprintf(lg->f, "[%lu] ", (unsigned long)getpid());



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel