Re: [Xen-devel] [PATCH v6 11/11] xen, common: do not implicitly permit access to mapped I/O memory

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Mon, 2014-04-21 at 15:45 +0200, Arianna Avanzini wrote:
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index 44d0453..33dc3ce 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -867,7 +867,10 @@ static int do_pci_add(libxl__gc *gc, uint32_t domid, 
> libxl_device_pci *pcidev, i
>          }
>          if ( rc )
>              return ERROR_FAIL;
> -        break;
> +        /*
> +         * fall through and let I/O memory permissions for PCI devices be 
> given
> +         * also to HVM domains
> +         */

With this in place I'm not sure the use of a switch is really the right
structure any more. How about:

    if (it's an HVM guest)
    {
        device model related stuff
    }

    the remaining common setup (what used to be PV specific)

? Same on remove.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel