Re: [Xen-devel] [PATCH v3 2/9] x86: move common_interrupt to entry.S

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.04.14 at 11:25, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 28/04/14 04:14, Feng Wu wrote:
>> This patch moves label common_interrupt from asm_defns.h to entry.S
>>
>> Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> 
> I am fairly sure the __asm__(".section .text"); was bogus, given no
> obvious special case hacks play with the sections of this file.

I'm fairly sure it's needed, and - what may make things worse - only
with some compiler versions: If the compiler emitted any data before
processing the file scope asm()s, the code generated here would end
up in that data section.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel