Re: [Xen-devel] [PATCH v3 2/9] x86: move common_interrupt to entry.S

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Monday, April 28, 2014 5:16 PM
> To: Wu, Feng
> Cc: andrew.cooper3@xxxxxxxxxx; ian.campbell@xxxxxxxxxx; Dong, Eddie;
> Nakajima, Jun; Tian, Kevin; xen-devel@xxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/9] x86: move common_interrupt to entry.S
> 
> >>> On 28.04.14 at 05:14, <feng.wu@xxxxxxxxx> wrote:
> > --- a/xen/arch/x86/i8259.c
> > +++ b/xen/arch/x86/i8259.c
> > @@ -33,10 +33,6 @@
> >   * interrupt-controller happy.
> >   */
> >
> > -__asm__(".section .text");
> 
> I don't think you can remove this without having removed ...
> 
> > -
> > -BUILD_COMMON_IRQ()
> > -
> >  #define IRQ_NAME(nr) VEC##nr##_interrupt
> >
> >  #define BI(nr)                                           \
> 
> ... everything from here downwards relating to the entry point
> construction.

I will add "__asm__(".section .text");" back.

> 
> With that fixed,
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks,
Feng

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel