Re: [Xen-devel] [PATCH v5 RESEND 07/17] x86/VPMU: Add public xenpmu.h

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.04.14 at 10:21, <kevin.tian@xxxxxxxxx> wrote:
>>  From: Boris Ostrovsky [mailto:boris.ostrovsky@xxxxxxxxxx]
>> +struct xen_arch_pmu {
>> +    union {
>> +        struct cpu_user_regs regs;
>> +        uint8_t pad1[256];
>> +    } r;
>> +    union {
>> +        uint32_t lapic_lvtpc;
>> +        uint64_t pad2;
>> +    } l;
>> +    union {
>> +        struct xen_pmu_amd_ctxt amd;
>> +        struct xen_pmu_intel_ctxt intel;
>> +        uint8_t pad3[XENPMU_CTXT_PAD_SZ];
>> +    } c;
>> +};
> 
> 'xen_' prefix is meaningless here, and suppose to sustain vpmu in the names.

If these were field names, I'd agree. But I specifically asked for xen_
prefixes on anything going at some kind of global scope (i.e. structure
name tags here).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel