[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [optional PATCH v3 01/11] hvm/hpet: Add manual unit test code.



On 04/23/14 10:41, Jan Beulich wrote:
On 17.04.14 at 19:42, <dslutz@xxxxxxxxxxx> wrote:
+hpet.h: $(XEN_ROOT)/xen/include/asm-x86/hpet.h
+       cp $(XEN_ROOT)/xen/include/asm-x86/hpet.h .
+
+hpet.c: $(XEN_ROOT)/xen/arch/x86/hvm/hpet.c
+       sed -e "/#include/d" -e "1i#include \"emul.h\"\n" 
<$(XEN_ROOT)/xen/arch/x86/hvm/hpet.c >hpet.c
Just as a general remark (I'm not myself intending to review or commit
this patch): You should try to use shortcuts when possible, i.e. $< and
$@ in both above rules.

Ok
   -Don Slutz

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.