Re: [Xen-devel] [PATCH] xen-acpi-processor: Don't display errors when we get -ENOSYS

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 25/04/14 16:10, Konrad Rzeszutek Wilk wrote:
> which is a perfectly legal error. This can be triggered if the
> user has booted Xen with the no-cpuidle parameter.
>
> Reported-by-and-Tested-by: Don Slutz <dslutz@xxxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---

It would be more appropriate for Xen to return -ENODEV if it understands
the ACPI hypercalls, but can't do anything with them.

That cat is however out of the bag.

~Andrew

>  drivers/xen/xen-acpi-processor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xen-acpi-processor.c 
> b/drivers/xen/xen-acpi-processor.c
> index 82358d1..59fc190 100644
> --- a/drivers/xen/xen-acpi-processor.c
> +++ b/drivers/xen/xen-acpi-processor.c
> @@ -127,7 +127,7 @@ static int push_cxx_to_hypervisor(struct acpi_processor 
> *_pr)
>                       pr_debug("     C%d: %s %d uS\n",
>                                cx->type, cx->desc, (u32)cx->latency);
>               }
> -     } else if (ret != -EINVAL)
> +     } else if ((ret != -EINVAL) && (ret != -ENOSYS))
>               /* EINVAL means the ACPI ID is incorrect - meaning the ACPI
>                * table is referencing a non-existing CPU - which can happen
>                * with broken ACPI tables. */
> @@ -259,7 +259,7 @@ static int push_pxx_to_hypervisor(struct acpi_processor 
> *_pr)
>                       (u32) perf->states[i].power,
>                       (u32) perf->states[i].transition_latency);
>               }
> -     } else if (ret != -EINVAL)
> +     } else if ((ret != -EINVAL) && (ret != -ENOSYS))
>               /* EINVAL means the ACPI ID is incorrect - meaning the ACPI
>                * table is referencing a non-existing CPU - which can happen
>                * with broken ACPI tables. */


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel