[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 6/8] tools: arm: refactor code to setup guest p2m and fill it with RAM
On Fri, 2014-04-25 at 14:12 +0100, Julien Grall wrote: > > On 25/04/14 13:59, Ian Campbell wrote: > >> It think we can avoid looping twice by making the two banks contiguous > >> in the memory (i.e starting the second bank at 4GB instead of 8GB). > > > > As explained in the commit message I have deliberately left a hole so > > that we can see that such configurations actually work. > > IHMO, the code path doesn't seem very complicate. Adding this overhead > (the two loop + the 1GB hole) just for it seems pointless. I disagree. It is always worth exercising these things, and this will make sure we don't bake in assumptions about using a single contiguous bank anywhere by mistake. I think you are overestimating the overhead and underestimating the benefit.0 > BTW, is there any issue to create one big bank rather than 2? I expect it would work just fine, but I am not going to do that either for the reasons already discussed. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |