[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 11/11] hvm/hpet: handle 1st period special
>>> On 17.04.14 at 19:43, <dslutz@xxxxxxxxxxx> wrote: > v3: > Better commit message. > More setting of first_mc64 & first_enabled when needed. > Switch to bool_t. > > xen/arch/x86/hvm/hpet.c | 83 > ++++++++++++++++++++++++++++++++++++------- > xen/include/asm-x86/hvm/vpt.h | 2 ++ > 2 files changed, 73 insertions(+), 12 deletions(-) I still can't help myself thinking that this must be achievable with less special casing - I just can't imagine that hardware also has this huge an amount of special case logic just for the first period. > @@ -208,12 +216,18 @@ static void hpet_stop_timer(HPETState *h, unsigned int > tn, > * 1/(2^10) second, namely, 0.9765625 milliseconds */ > #define HPET_TINY_TIME_SPAN ((h->stime_freq >> 10) / STIME_PER_HPET_TICK) > > +static void hpet_time_fired(struct vcpu *v, void *priv) > +{ > + bool_t *first_enabled_p = (bool_t *)priv; Pointless cast. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |