Re: [Xen-devel] [PATCH v2 5/8] tools: arm: prepare for multiple banks of guest RAM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-25 at 13:19 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 25/04/14 12:22, Ian Campbell wrote:
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index 4149d6f..c4f4990 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -374,8 +374,12 @@ typedef uint64_t xen_callback_t;
> >
> >   #define GUEST_MAGIC_BASE  0x39000000ULL
> >
> > -#define GUEST_RAM_BASE    0x40000000ULL /* 3GB of RAM @ 1GB */
> > -#define GUEST_RAM_SIZE    0xc0000000ULL
> > +#define GUEST_RAM0_BASE   0x40000000ULL /* 3GB of RAM @ 1GB */
> > +#define GUEST_RAM0_SIZE   0xc0000000ULL
> > +
> > +#define GUEST_RAM_BASE    GUEST_RAM0_BASE /* Lowest RAM address */
> 
> Is it necessary to define GUEST_RAM_BASE? I don't see any usage of this 
> define in this patch series.

$ git grep GUEST_RAM_BASE
tools/libxl/libxl_dom.c:#ifdef GUEST_RAM_BASE
tools/libxl/libxl_dom.c:    if ( (ret = xc_dom_rambase_init(dom, GUEST_RAM_BASE

(this then ties back to the assert in arch_setup_meminit)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel