Re: [Xen-devel] [PATCH] vtpmmgr: fix 32-bit compilation

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-25 at 08:44 +0100, Jan Beulich wrote:
> >>> On 25.04.14 at 09:25, <Ian.Campbell@xxxxxxxxxx> wrote:
> > Your review all looks valid to me, but I wonder if we ought we take this
> > patch now to unwedge the push gate and fixup those issues later? 
> > 
> > Given the time zone differences I expect it will be fairly late (my)
> > afternoon before we see a response and fresh patch from Daniel, which
> > runs the risk of my not being able to apply it before the weekend.
> > 
> > Or I could revert the half dozen patches I called out previously.
> > 
> > Or maybe we don't care about leaving the tree broken over the w/e, it is
> > the middle of the development cycle after all... On the flip side there
> > are 47 patches in staging right now, including XSA-93 and -94.
> > 
> > What do you think? Are your comments showstoppers? (the last one about
> > trailing bits looks like it might be...)
> 
> No, I think you should go ahead and apply the patch as is to allow
> things to progress over the weekend.

OK, so I've acked + applied this.

(I didn't add your ack, since I think your review comments will overrule
your special case "go ahead" in the historical context)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel