Re: [Xen-devel] handling local attach of phy disks for pygrub (Was: Xen 4.3 xl migrate " htree_dirblock_to_tree" on second host)

[Miguel Clara <miguelmclara@xxxxxxxxx>]

Sorry totally forgot about this, was looking into other stuff with Xen... need to re-check this and ping you back later... maybe tomorrow, today will be complicated.

Thanks for the reminder.

On Wed, Apr 23, 2014 at 11:48 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

On Wed, 2014-03-12 at 14:06 +0000, Ian Campbell wrote:
> On Wed, 2014-02-12 at 11:46 +0100, Roger Pau Monnà wrote:
>
> > I though this was already working on libxl... Could you please test the
> > attached patch? Which is basically the chunk Ian posted above plus the
> > libxl__device_disk_local_initiate_detach part.
>
> Did this patch work?

Ping? Miguel, I think this is waiting for you to confirm that it fixes
your issue.

> >
> > ---
> > commit 3bcf91cbbd9a18db9ae7d594ffde7979774ed512

> > Author: Roger Pau Monne <roger.pau@xxxxxxxxxx>

> > Date: Â Wed Feb 12 11:15:17 2014 +0100
> >
> > Â Â libxl: local attach support for PHY backends using scripts
> >
> > Â Â Allow disks using the PHY backend to locally attach if using a script.

> >
> >   Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>

> > Â Â Suggested-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index 730f6e1..5cb46a1 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -2630,6 +2630,16 @@ void libxl__device_disk_local_initiate_attach(libxl__egc *egc,
> >
> > Â Â Âswitch (disk->backend) {
> > Â Â Â Â Âcase LIBXL_DISK_BACKEND_PHY:
> > + Â Â Â Â Â Âif (disk->script != NULL) {
> > + Â Â Â Â Â Â Â ÂLOG(DEBUG, "trying to locally attach PHY device %s with script %s",
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â disk->pdev_path, disk->script);
> > + Â Â Â Â Â Â Â Âlibxl__prepare_ao_device(ao, &dls->aodev);
> > + Â Â Â Â Â Â Â Âdls->aodev.callback = local_device_attach_cb;
> > + Â Â Â Â Â Â Â Âdevice_disk_add(egc, LIBXL_TOOLSTACK_DOMID, disk,
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&dls->aodev, libxl__alloc_vdev,
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â(void *) blkdev_start);
> > + Â Â Â Â Â Â Â Âreturn;
> > + Â Â Â Â Â Â}
> > Â Â Â Â Â Â ÂLIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "locally attaching PHY disk %s",
> > Â Â Â Â Â Â Â Â Â Â Â Â disk->pdev_path);
> > Â Â Â Â Â Â Âdev = disk->pdev_path;
> > @@ -2709,7 +2719,7 @@ static void local_device_attach_cb(libxl__egc *egc, libxl__ao_device *aodev)
> > Â Â Â}
> >
> > Â Â Âdev = GCSPRINTF("/dev/%s", disk->vdev);
> > - Â ÂLOG(DEBUG, "locally attaching qdisk %s", dev);
> > + Â ÂLOG(DEBUG, "locally attached disk %s", dev);
> >
> > Â Â Ârc = libxl__device_from_disk(gc, LIBXL_TOOLSTACK_DOMID, disk, &device);
> > Â Â Âif (rc < 0)
> > @@ -2749,6 +2759,7 @@ void libxl__device_disk_local_initiate_detach(libxl__egc *egc,
> > Â Â Âif (!dls->diskpath) goto out;
> >
> > Â Â Âswitch (disk->backend) {
> > + Â Â Â Âcase LIBXL_DISK_BACKEND_PHY:
> > Â Â Â Â Âcase LIBXL_DISK_BACKEND_QDISK:
> > Â Â Â Â Â Â Âif (disk->vdev != NULL) {
> > Â Â Â Â Â Â Â Â ÂGCNEW(device);
> > @@ -2766,7 +2777,6 @@ void libxl__device_disk_local_initiate_detach(libxl__egc *egc,
> > Â Â Â Â Â Â Â/* disk->vdev == NULL; fall through */
> > Â Â Â Â Âdefault:
> > Â Â Â Â Â Â Â/*
> > - Â Â Â Â Â Â * Nothing to do for PHYSTYPE_PHY.
> > Â Â Â Â Â Â Â * For other device types assume that the blktap2 process is
> > Â Â Â Â Â Â Â * needed by the soon to be started domain and do nothing.
> > Â Â Â Â Â Â Â */
> >
> >
> >
> >
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel