[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2 1/4] xen: make logdirty and iommu mutually exclusive
On 24/04/14 09:36, Roger Pau Monné wrote: > On 23/04/14 11:54, Jan Beulich wrote: >>>>> On 23.04.14 at 10:16, <roger.pau@xxxxxxxxxx> wrote: >>> --- a/xen/drivers/passthrough/iommu.c >>> +++ b/xen/drivers/passthrough/iommu.c >>> @@ -292,7 +292,8 @@ static int assign_device(struct domain *d, u16 seg, u8 >>> bus, u8 devfn) >>> * enabled for this domain */ >>> if ( unlikely(!need_iommu(d) && >>> (d->arch.hvm_domain.mem_sharing_enabled || >>> - d->mem_event->paging.ring_page)) ) >>> + d->mem_event->paging.ring_page || >>> + paging_mode_log_dirty(d))) ) >> >> I'm afraid that would return true also for non-global log dirty mode. >> This patch series >> http://lists.xenproject.org/archives/html/xen-devel/2014-04/msg02750.html >> (patch 1) introduces a way to know whether global mode is enabled >> - maybe you should base your series on top of that one? > > Sure, this series are already on top of Mukesh p2m cleanup patches, I > don't mind rebasing it on top of your series also. I'm afraid I will have to wait for either you or Mukesh to rebase on top of each other, since your patches don't apply cleanly on top of Mukesh's p2m changes. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |