Re: [Xen-devel] [PATCH osstest] apt: lock osstest's usages of apt-get against each other

[Ian Campbell <ijc@xxxxxxxxxxxxxx>]

On Thu, 2014-04-24 at 12:18 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH osstest] apt: lock osstest's usages of apt-get 
> against each other"):
> > From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > Currently we rely on all apt-get invocations being in a single
> > ts-xen-build-prep job which can't run on a shared host.
> ...
> > @@ -430,17 +430,18 @@ sub target_putfile_root ($$$$;$) {
> >  sub target_run_apt {
> >      my ($ho, $timeout, @aptopts) = @_;
> 
> I think this needs to lose the timeout option completely.  If some new
> caller were to come along and call "apt-get moo", it ought not to be
> expected to pass a timeout.  If it did it would pass 30, one would
> expect, but of course it might end up blocked behind a long run.

I think you mean this function should just pick a suitably large timeout
for everything, rather than have no timeout at all, is that right?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel