Re: [Xen-devel] [OSSTest PATCH] More Debian HVM testcases

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Apr 24, 2014 at 09:36:53AM +0100, Ian Campbell wrote:
> On Wed, 2014-04-23 at 18:26 +0100, Wei Liu wrote:
> > diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install
> > index c322d6b..f7ef549 100755
> > --- a/ts-debian-hvm-install
> > +++ b/ts-debian-hvm-install
> > @@ -28,7 +28,13 @@ if (@ARGV && $ARGV[0] =~ m/^--stage(\d+)$/) { $stage=$1; 
> > shift @ARGV; }
> >  
> >  our ($whhost,$gn) = @ARGV;
> >  $whhost ||= 'host';
> > -$gn ||= 'ovmf';
> > +defined($r{bios}) or die "Need to define which bios to use";
> > +if ($r{bios} =~ /ovmf/m) {
> > +    $gn ||= 'ovmf';
> > +} else {
> > +    # rombios or seabios
> > +    $gn ||= 'debianhvm';
> > +}
> 
> Does the the guest name matter all that much? Can't it just be debianhvm
> regardless of the BIOS type? That would simplify this and sg-run-jobs
> wouldn't it?
> 

Yes this can be done. What really matters is the bios parameter passed in.

> In any case I'd think that sg-run-jobs ought to supply the name by
> default, i.e. 
> 
> proc need-hosts/test-debianhvm-ovmf {} { return host }
> proc run-job/test-debianhvm-ovmf {} {
>     run-ts . = ts-debian-hvm-install ovmf
>     test-guest ovmf
> }
> 
> proc need-hosts/test-debianhvm {} { return host }
> proc run-job/test-debianhvm {} {
>     run-ts . = ts-debian-hvm-install debianhvm
>     test-guest debianhvm
> }
> 
> (and presumably this could then be refactored into a common function
> with name parameter)
> 
>  

I think this can be done. Time to learn some TCL...

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel