[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 1/2] SVM: support data breakpoint extension registers
On Wed, 2014-04-16 at 15:33 +0100, Jan Beulich wrote: > Leveraging the generic MSR save/restore logic introduced a little while > ago. > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > Tested-by: Aravind Gopalakrishnan<aravind.gopalakrishnan@xxxxxxx> > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx> > > --- a/tools/libxc/xc_cpufeature.h > +++ b/tools/libxc/xc_cpufeature.h > @@ -125,6 +125,7 @@ > #define X86_FEATURE_NODEID_MSR 19 /* NodeId MSR */ > #define X86_FEATURE_TBM 21 /* trailing bit manipulations */ > #define X86_FEATURE_TOPOEXT 22 /* topology extensions CPUID leafs */ > +#define X86_FEATURE_DBEXT 26 /* data breakpoint extension */ > > /* Intel-defined CPU features, CPUID level 0x00000007:0 (ebx) */ > #define X86_FEATURE_FSGSBASE 0 /* {RD,WR}{FS,GS}BASE instructions */ > --- a/tools/libxc/xc_cpuid_x86.c > +++ b/tools/libxc/xc_cpuid_x86.c > @@ -110,9 +110,10 @@ static void amd_xc_cpuid_policy( > bitmaskof(X86_FEATURE_3DNOWPREFETCH) | > bitmaskof(X86_FEATURE_OSVW) | > bitmaskof(X86_FEATURE_XOP) | > + bitmaskof(X86_FEATURE_LWP) | > bitmaskof(X86_FEATURE_FMA4) | > bitmaskof(X86_FEATURE_TBM) | > - bitmaskof(X86_FEATURE_LWP)); > + bitmaskof(X86_FEATURE_DBEXT)); > regs[3] &= (0x0183f3ff | /* features shared with 0x00000001:EDX */ > (is_pae ? bitmaskof(X86_FEATURE_NX) : 0) | > (is_64bit ? bitmaskof(X86_FEATURE_LM) : 0) | > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -3080,6 +3080,9 @@ void hvm_cpuid(unsigned int input, unsig > /* Only provide PSE36 when guest runs in 32bit PAE or in long mode */ > if ( !(hvm_pae_enabled(v) || hvm_long_mode_enabled(v)) ) > *edx &= ~cpufeat_mask(X86_FEATURE_PSE36); > + /* Hide data breakpoint extensions if the hardware has not support. > */ s/not/no/ is more grammatical. Other than that for the tools bit (and I realise I overshot with that comment): Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |