Re: [Xen-devel] [PATCH V9 09/12] libxl: use the API to setup/teardown network buffering

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yang Hongyang writes ("[PATCH V9 09/12] libxl: use the API to setup/teardown 
network buffering"):
> ---
...
>      /* Point of no return */
> -    libxl__domain_suspend(egc, dss);
> +    libxl__remus_setup_initiate(egc, dss);

I think this patch may need to become part of some other patch; see my
other comments.

> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index b72643b..3c0f94d 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -2467,6 +2467,9 @@ typedef struct libxl__remus_state {
>      int saved_rc;
>      /* Opaque context containing device related stuff */
>      void *device_state;
> +
> +    /* used for checkpoint */
> +    libxl__ev_time timeout;

There are no calls which actually set this timeout.  Nor any which
clean it up.  Obviously some important moving parts are missing here.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel