Re: [Xen-devel] [PATCH v4 18/18] xen/arm: IRQ: Handle multiple action per IRQ

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/23/2014 04:16 PM, Ian Campbell wrote:
> On Wed, 2014-04-23 at 15:56 +0100, Julien Grall wrote:
>>>> +        do
>>>> +        {
>>>> +            action->handler(irq, action->dev_id, regs);
>>>> +            action = action->next;
>>>> +        } while ( action );
>>>
>>> What happens if action is freed and recycled in the midst of this loop?
>>
>> Nothing, the action won't be free until IRQ_INPROGRESS is set (see do ..
>> while at the end of release_irq).
> 
> BY that logic wasn't the version which used the list macros also safe
> then?

No because we had to modify two pointers (next and prev). Here as we
modify only one pointer, do_IRQ may or may not call action for a last time.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel